Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry 'test_transaction_read_and_insert_then_rollback' when aborted. #5737

Merged
merged 1 commit into from
Aug 6, 2018
Merged

Retry 'test_transaction_read_and_insert_then_rollback' when aborted. #5737

merged 1 commit into from
Aug 6, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 2, 2018

Closes #5718.

@tseaver tseaver added testing api: spanner Issues related to the Spanner API. flaky labels Aug 2, 2018
@tseaver tseaver requested a review from theacodes August 2, 2018 21:03
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 2, 2018
@tseaver tseaver requested review from mcdonc and removed request for theacodes August 6, 2018 17:37
mcdonc
mcdonc approved these changes Aug 6, 2018
View reviewed changes
Copy link
Contributor

@mcdonc mcdonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tseaver tseaver merged commit e4472a2 into master Aug 6, 2018
@tseaver tseaver deleted the 5718-spanner-harden-read_insert_rollback-systest branch August 6, 2018 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonc mcdonc mcdonc approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. flaky testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @mcdonc @googlebot